Type Annotations #35
Merged
Type Annotations #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
reviewed
Sep 28, 2021
FoamyGuy
requested changes
Sep 28, 2021
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
Re-running mypy on this branch I found one set of arguments missed.
Beyond that, things are looking pretty good to me.
I was able to successfully import from the library on a Feather S2:
from adafruit_max7219 import matricesBut have not performed more in depth testing. I did find one of these chips in my parts bin though so I'll try to get everything wired up to test it in the next few days.
Contributor
|
Thank you for updating the docstrings and fixing the comment that referenced the wrong chip / device! |
FoamyGuy
approved these changes
Oct 2, 2021
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
These changes look good to me. Tested successfully on:
Adafruit CircuitPython 7.0.0 on 2021-09-20; Adafruit Feather RP2040 with rp2040
Board ID:adafruit_feather_rp2040
Thanks again for working on this @FlantasticDan
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 3, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX7219 to 1.4.0 from 1.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#35 from FlantasticDan/type-annotations > Globally disabled consider-using-f-string pylint check > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP40 to 1.3.1 from 1.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_SGP40#13 from caternuson/iss12_pypi > Globally disabled consider-using-f-string pylint check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements type annotations as described by #34:
As I was going through adding types, I also updated the docstrings to match the function call.