i2c_device: adjust for removal of stop=, compatibly #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version prints (to the serial console) a message about the deprecation. Then we can remove it *HERE* in a future release.
This was referenced Jul 26, 2020
dhalbert
reviewed
Jul 26, 2020
Contributor
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
I think you could just remove it, without the warning. We've already prepped for this, and the library changes make it final.
The print() may not be seen by many people, and it's going to print on every write().
|
Tested with CP 6.0.0-alpha2 on metro_m4_express with 2 I2C devices (aht20 and msa301) -- both work normally -- Thank you! |
Contributor
|
Closed in favor of #55. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version prints (to the serial console) a message about the deprecation. Then we can remove it HERE in a future release.
I can provide a version which just removes it right now, if that's preferable.
Testing performed: with 6.0.0.a2 on an Adafruit Clue, can instantiate the LSM6DS33 object