Added dew point, updated example #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
looks good to me, just need a linty and ill merge! |
Contributor
Author
|
I |
ladyada
approved these changes
Aug 13, 2018
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 14, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME280 to 2.1.0 from 2.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_BME280#12 from kattni/add-dew-point
Member
|
Sorry I didn't get to this sooner. I don't think it should go in this library because its not specific to the BME280 at all. Please remove it so people don't start using it. Instead, a generic Python library like meteocalc should be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added per #11
Added dew point calculation using Magnus formula. Checked against online dew point calculator, matches. Updated example to include dew point reading.