Fix __get__ in CPython. - #69
Merged
Merged
Conversation
In CPython, obj is None when a descriptor is accessed through a class rather than an instance. MicroPython just returns the descriptor itself so we manually do it.
dhalbert
approved these changes
Feb 19, 2020
dhalbert
left a comment
dhalbert
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Should an issue be filed on MicroPython?
Member
Author
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 20, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 5.2.0 from 5.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#70 from tannewt/swap_blinka_dep > Merge pull request adafruit/Adafruit_CircuitPython_BLE#69 from tannewt/check_for_obj_none Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_BLE_Eddystone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CPython, obj is None when a descriptor is accessed through a class
rather than an instance. MicroPython just returns the descriptor itself
so we manually do it.