Prevent unbounded BLERadio._connection_cache growth from causing memory exhaustion (issue #146) #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger valid. This prevents unbounded cache growth from causing memory exhaustion as described in github issue #146.
tannewt
approved these changes
Dec 13, 2021
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Nice find! I like the approach you take here. Thanks for the fix!
Author
|
@tannewt Thanks for the comment - much appreciated! :) |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 17, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.1.3 from 8.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#147 from 300bps/main Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.15.2 from 1.15.1: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#67 from FoamyGuy/widget_int_fix > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#65 from Neradoc/patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch prevents the issue described in #146 from causing memory exhaustion that leads to app hang/crash.
The approach taken was to purge the cache of stale connection entries that have been disconnected each time a new connection is added to the cache.