Skip to content

Conversation

@technobly
Copy link
Contributor

@technobly technobly commented Aug 15, 2025

I think I fixed everything with black and pylint, just needs platform detect changes merged first?

@technobly technobly force-pushed the for-upstream branch 2 times, most recently from 6476382 to acd991a Compare August 15, 2025 21:32
@makermelissa
Copy link
Collaborator

Looks likeI need to do a release of platform detect first...

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@makermelissa makermelissa merged commit bfd903b into adafruit:main Aug 16, 2025
1 of 2 checks passed
@ladyada
Copy link
Member

ladyada commented Aug 16, 2025

@makermelissa did you check the changes to libgpio.py code? @technobly why were those changes made?

@technobly
Copy link
Contributor Author

@ladyada IIRC it was erroring when I tried running with libgpiod v2.1.3
If you don't have an easy way to check it, you can revert it because currently Tachyon uses v1.4.1 of libgpiod on ubuntu v20.04. v2.x should be supported in ubuntu 24.04 when that is released for Tachyon, so we'll need it soon enough though.

makermelissa added a commit to makermelissa/Adafruit_Blinka that referenced this pull request Aug 16, 2025
@makermelissa
Copy link
Collaborator

I reverted the libgpiod changes in #1003. @technobly, if you find an error, please open up a new issue in the future. Thanks.

makermelissa added a commit that referenced this pull request Aug 16, 2025
Rollback breaking libgpiod changes from #1001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants