Fix error with 'Add existing record' using record_select#229
Merged
scambra merged 1 commit intoactivescaffold:masterfrom Jan 22, 2013
Envek:fix_add_existing_record_using_RS
Merged
Fix error with 'Add existing record' using record_select#229scambra merged 1 commit intoactivescaffold:masterfrom Envek:fix_add_existing_record_using_RS
scambra merged 1 commit intoactivescaffold:masterfrom
Envek:fix_add_existing_record_using_RS
Conversation
scambra
added a commit
that referenced
this pull request
Jan 22, 2013
Fix error with 'Add existing record' using record_select
Member
|
Thank you |
This was referenced Jan 28, 2013
scambra
pushed a commit
that referenced
this pull request
Feb 25, 2015
Backport of #229 for the 3.2.x versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Active Scaffold 3.2.12 (possibly in d7d2a14) was introduced a bug, that fires javascript error on selecting a record from record_select in 'Add existing record'.
The reason is an URL, that in that version and above become an javascript Object (Ruby hash), not a String.
Affected versions: rails-3.2 branch (
/frontends/default/views/_form_association_footer.html.erb:37) version 3.2.12 and above and master branch (app/views/active_scaffold_overrides/_form_association_footer.html.erb:37).There is a quick fix for master branch.