Allow NO_SSL_VERIFY in RawHttpMessageHandler. #3883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for skipping SSL certificate validation in RawHttpMessageHandler when the GITHUB_ACTIONS_RUNNER_TLS_NO_VERIFY environment variable is set.
- Applies the configured
ServerCertificateValidationCallbackto the transport handler inRawHttpMessageHandleronce per handler for HTTPS requests. - Adds a backing field (
m_appliedServerCertificateValidationCallbackToTransportHandler) to track application of the callback. - Updates
VssUtilto setRawClientHttpRequestSettings.Default.ServerCertificateValidationCallbackalongside the existing setting.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Sdk/Common/Common/RawHttpMessageHandler.cs | Apply ServerCertificateValidationCallback on HTTPS transport handlers and track with a flag. |
| src/Runner.Sdk/Util/VssUtil.cs | Configure RawClientHttpRequestSettings for NO_SSL_VERIFY environment variable. |
Comments suppressed due to low confidence (2)
src/Sdk/Common/Common/RawHttpMessageHandler.cs:109
- Use the
Uri.UriSchemeHttpsconstant and a case-insensitive comparison for clarity and consistency, e.g.,request.RequestUri.Scheme.Equals(Uri.UriSchemeHttps, StringComparison.OrdinalIgnoreCase).
if (!m_appliedServerCertificateValidationCallbackToTransportHandler && request.RequestUri.Scheme == "https")
src/Sdk/Common/Common/RawHttpMessageHandler.cs:109
- Add unit tests under
Test/L0to verify that whenGITHUB_ACTIONS_RUNNER_TLS_NO_VERIFYis enabled,RawHttpMessageHandlercorrectly applies theDangerousAcceptAnyServerCertificateValidatorcallback.
if (!m_appliedServerCertificateValidationCallbackToTransportHandler && request.RequestUri.Scheme == "https")
| if (StringUtil.ConvertToBoolean(Environment.GetEnvironmentVariable("GITHUB_ACTIONS_RUNNER_TLS_NO_VERIFY"))) | ||
| { | ||
| VssClientHttpRequestSettings.Default.ServerCertificateValidationCallback = HttpClientHandler.DangerousAcceptAnyServerCertificateValidator; | ||
| RawClientHttpRequestSettings.Default.ServerCertificateValidationCallback = HttpClientHandler.DangerousAcceptAnyServerCertificateValidator; |
There was a problem hiding this comment.
[nitpick] Update the public README or configuration documentation to mention the new GITHUB_ACTIONS_RUNNER_TLS_NO_VERIFY environment variable and its effect on raw HTTP handlers.
ericsciple
approved these changes
May 30, 2025
This was referenced Jun 3, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
LouisHaftmann
pushed a commit
to falcondev-oss/github-actions-runner
that referenced
this pull request
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.