Cleanup feature flag actions_skip_retry_complete_job_upon_known_errors #3806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes legacy feature flag support for "actions_skip_retry_complete_job_upon_known_errors" to simplify job completion logic. Key changes include:
- Removing the conditional branch that calls CompleteJob2Async and its associated catch filters in JobRunner.cs.
- Eliminating the CompleteJob2Async method from the RunServer interface in RunServer.cs.
- Deleting the SkipRetryCompleteJobUponKnownErrors constant from Constants.cs.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Runner.Worker/JobRunner.cs | Removed conditional logic based on the feature flag and updated exception handling. |
| src/Runner.Common/RunServer.cs | Removed legacy CompleteJob2Async method and related implementation. |
| src/Runner.Common/Constants.cs | Removed the deprecated feature flag constant. |
Comments suppressed due to low confidence (2)
src/Runner.Common/RunServer.cs:32
- Ensure that all references to 'CompleteJob2Async' have been completely removed after deprecation to avoid any unintentional calls or interface mismatches in the future.
Task CompleteJob2Async(
src/Runner.Worker/JobRunner.cs:324
- The removal of the feature flag check in the catch block changes the exception handling behavior. Please confirm that this uniform approach to handling VssUnauthorizedException is intentional and does not hide side effects previously gated by the flag.
catch (VssUnauthorizedException ex)
yaananth
approved these changes
Apr 11, 2025
marko-k0
pushed a commit
to dfinity/runner
that referenced
this pull request
May 13, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: