Skip to content

Conversation

@AshUK
Copy link

@AshUK AshUK commented Nov 18, 2020

Description

Adds clang 11 to the clang installer and bumps the default version, tested on a private ubuntu server

Related issue:

#1882

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@al-cheb
Copy link
Contributor

al-cheb commented Nov 18, 2020

Hello, @AshUK
Could you please remove changes related to auto-generated documentation file Ubuntu2004-README.md ?

@maxim-lobanov
Copy link
Contributor

/azp run ubuntu1604, ubuntu1804, ubuntu2004

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@miketimofeev
Copy link
Contributor

@AshUK could you please pull the latest main? We've made some significant changes there so your branch is not working anymore.

@AlenaSviridenko
Copy link
Contributor

/azp run ubuntu2004

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@miketimofeev
Copy link
Contributor

@AshUK looks like there is no clang-11 package for Ubuntu-20 yet
https://packages.ubuntu.com/search?keywords=clang-&searchon=names&suite=focal&section=all
Build failed with

==> azure-arm: E: Unable to locate package clang-11
==> azure-arm: E: Unable to locate package lldb-11
==> azure-arm: E: Unable to locate package lld-11
==> azure-arm: E: Unable to locate package clang-format-11
    azure-arm: Testing to make sure that script performed as expected, and basic scenarios work
    azure-arm: clang-11 was not installed

@AshUK
Copy link
Author

AshUK commented Dec 2, 2020

@miketimofeev This looks to be true, the test server I have used seems to have had the llvm repository previously installed, I thought it was a clean server. I have updated the PR to use the external llvm installer when installing clang-11 on ubuntu 20.

What I am not unsure of is how install was successful on 16 and 18 as when searching the official ubuntu packages clang-11 is not available on these platform either.

@AlenaSviridenko can you please run all three pipelines again.

@AlenaSviridenko
Copy link
Contributor

/azp run ubuntu1604, ubuntu1804, ubuntu2004

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@miketimofeev
Copy link
Contributor

@AshUK could you please pull the latest main to your branch? We've just fixed an issue, which breaks the builds #2184
I'll rerun the builds after that. Sorry for the inconvenience!

@miketimofeev
Copy link
Contributor

@AshUK I'm afraid we forgot about the issue related to llvm #1536 (comment)
Therefore it's better to wait until clang-11 is added to the official ubuntu to avoid the issue.

@maxim-lobanov
Copy link
Contributor

I am closing this PR since as @miketimofeev mentioned we install clang only from default repo. Installing from llvm repo cause issues mentioned above. We will be able to accept this contribution when CLang is added to default repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants