Make the major version release workflow consistent with other Actions#53
Merged
JamesMGreene merged 2 commits intomainfrom Aug 19, 2022
Merged
Make the major version release workflow consistent with other Actions#53JamesMGreene merged 2 commits intomainfrom
JamesMGreene merged 2 commits intomainfrom
Conversation
yoannchaudet
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on:
Most importantly, this repo's workflow is NOT currently being gated for a manual approval.
The
editedevent will trigger whenever the text, etc. is updated, even if the release is not published yet.The
publishedevent will trigger for both release and pre-release publishing, so that is not ideal either.Looks like the best option is the
releasedevent.https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release