Skip to content

Fix hardcoded api endpoint and artifact name lookup#46

Merged
YiMysty merged 12 commits intomainfrom
bug-fixing
Aug 5, 2022
Merged

Fix hardcoded api endpoint and artifact name lookup#46
YiMysty merged 12 commits intomainfrom
bug-fixing

Conversation

@YiMysty
Copy link
Contributor

@YiMysty YiMysty commented Aug 4, 2022

Fix hardcode api endpoint and artifact name
image

headers: {
Accept: 'application/vnd.github.v3+json',
Authorization: 'Bearer ',
Authorization: `Bearer gha-token`,

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "Bearer gha-token" is used as [authorization header](1).
{
headers: {
Authorization: 'token '
Authorization: 'token gha-token'

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "token gha-token" is used as [authorization header](1).
@YiMysty YiMysty marked this pull request as ready for review August 5, 2022 00:13
@YiMysty YiMysty requested a review from a team as a code owner August 5, 2022 00:13
uses: actions/setup-node@v2
with:
node-version: 12.x
node-version: 16.x
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump up test node version to benefit from some syntax sugar...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants