Merged
Conversation
GrantBirki
added
documentation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…t of the 'all' script
|
|
||
| it('executes cleanly', done => { | ||
| const ip = path.join(__dirname, '../index.js') | ||
| cp.exec(`node ${ip}`, { env: process.env }, (err, stdout) => { |
Check warning
Code scanning / CodeQL
Shell command built from environment values
| it('execution fails if there are missing variables', done => { | ||
| delete process.env.ACTIONS_RUNTIME_URL | ||
| const ip = path.join(__dirname, '../index.js') | ||
| cp.exec(`node ${ip}`, { env: process.env }, (err, stdout) => { |
Check warning
Code scanning / CodeQL
Shell command built from environment values
JamesMGreene
approved these changes
Apr 18, 2023
Contributor
JamesMGreene
left a comment
JamesMGreene
left a comment
There was a problem hiding this comment.
Thanks for the contributions! Lots of great nuggets within this PR. 💝 😍
I've taken the liberty of rolling back some of the changes that didn't feel especially relevant or desirable. ⏪
In the future, I would encourage a handful of smaller PRs instead of one large PR, as that typically results in less effort needed to get the favorable bits merged. 🙏🏻 🙇🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Repository Improvements
This pull request does the following:
CODEOWNERSfileCONTRIBUTING.mdfile for new contributors__tests__andsrc/dir withfunctionsfolder