Skip to content

Deprecate the conclusion parameter for the Action#125

Merged
JamesMGreene merged 2 commits intomainfrom
deprecate-conclusion-param
Mar 3, 2023
Merged

Deprecate the conclusion parameter for the Action#125
JamesMGreene merged 2 commits intomainfrom
deprecate-conclusion-param

Conversation

@JamesMGreene
Copy link
Contributor

As the added deprecationMessage states:

Use of this input does nothing as it was part of the deprecated emit_telemetry flow. You should remove this parameter from your workflow.

Both the emit_telemetry and conclusion parameters should be removed when we eventually cut a v2 release. ⏳

@JamesMGreene JamesMGreene requested a review from a team as a code owner February 22, 2023 14:38
@yoannchaudet
Copy link
Contributor

Nice, didn't know about deprecationMessage!

@JamesMGreene
Copy link
Contributor Author

Nice, didn't know about deprecationMessage!

Yeah! It was new to me as well when @TooManyBees introduced it for emit_telemetry in PR #75

@JamesMGreene JamesMGreene enabled auto-merge March 3, 2023 20:12
@JamesMGreene JamesMGreene merged commit 90e90be into main Mar 3, 2023
@JamesMGreene JamesMGreene deleted the deprecate-conclusion-param branch March 3, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants