Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs a major architectural refactoring of actions/attest-build-provenance for v4, converting it from a standalone TypeScript action into a lightweight composite action wrapper around actions/[email protected]. The change consolidates attestation functionality into the actions/attest action while maintaining backward compatibility for existing users.
Changes:
- Removed all TypeScript source code, tests, build configurations, and dependencies
- Converted action.yml from a Node.js action to a composite action that passes inputs through to
actions/[email protected] - Added new optional inputs (predicate-type, predicate, predicate-path) to support custom attestations in addition to build provenance
- Updated documentation to guide users toward
actions/attestfor new implementations
Reviewed changes
Copilot reviewed 19 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| action.yml | Converted to composite action wrapping actions/[email protected]; added new predicate inputs and storage-record-ids output |
| README.md | Updated to indicate v4 is a wrapper and direct users to actions/attest for new implementations |
| src/main.ts, src/index.ts | Removed TypeScript source code (no longer needed) |
| predicate/action.yml | Removed internal predicate action (functionality now in actions/attest) |
| package.json, package-lock.json | Removed Node.js dependencies (no longer a TypeScript action) |
| tsconfig.json, tsconfig.lint.json | Removed TypeScript configurations |
| eslint.config.mjs, .prettierrc.json, .prettierignore, .markdown-lint.yml | Removed linting and formatting configs |
| jest.setup.js, tests/* | Removed unit tests (integration test remains in CI) |
| dist/* | Removed bundled JavaScript (no longer needed for composite action) |
| .node-version | Removed Node.js version specification |
| .github/workflows/ci.yml | Simplified to remove TypeScript tests, kept integration test |
| .github/workflows/codeql-analysis.yml, .github/workflows/check-dist.yml | Removed workflows no longer needed without TypeScript code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Brian DeHamer <[email protected]>
9dcf1cb to
f2e271b
Compare
|
Is the migration as simple as replacing |
kristentr
added a commit
to kristentr/attest-build-provenance
that referenced
this pull request
Mar 3, 2026
* Add CodeQL analysis workflow configuration * Add CodeQL analysis workflow configuration * prepare v4 release (actions#835) Signed-off-by: Brian DeHamer <[email protected]> * update RELEASE.md docs (actions#836) Signed-off-by: Brian DeHamer <[email protected]> * bump actions/attest from 4.0.0 to 4.1.0 (actions#838) Signed-off-by: Brian DeHamer <[email protected]> * remove prober workflows (actions#837) Signed-off-by: Brian DeHamer <[email protected]> * Add commands to create and update actions-main branch Signed-off-by: Kristen T. Tran <[email protected]> --------- Signed-off-by: Brian DeHamer <[email protected]> Signed-off-by: Kristen T. Tran <[email protected]> Co-authored-by: Brian DeHamer <[email protected]>
kristentr
added a commit
to kristentr/attest-build-provenance
that referenced
this pull request
Mar 9, 2026
* prepare v4 release (actions#835) Signed-off-by: Brian DeHamer <[email protected]> * update RELEASE.md docs (actions#836) Signed-off-by: Brian DeHamer <[email protected]> * bump actions/attest from 4.0.0 to 4.1.0 (actions#838) Signed-off-by: Brian DeHamer <[email protected]> * remove prober workflows (actions#837) Signed-off-by: Brian DeHamer <[email protected]> * remove badges from README (actions#840) Signed-off-by: Brian DeHamer <[email protected]> --------- Signed-off-by: Brian DeHamer <[email protected]> Co-authored-by: Brian DeHamer <[email protected]>
kristentr
added a commit
to kristentr/attest-build-provenance
that referenced
this pull request
Mar 9, 2026
* prepare v4 release (actions#835) Signed-off-by: Brian DeHamer <[email protected]> * update RELEASE.md docs (actions#836) Signed-off-by: Brian DeHamer <[email protected]> * bump actions/attest from 4.0.0 to 4.1.0 (actions#838) Signed-off-by: Brian DeHamer <[email protected]> * remove prober workflows (actions#837) Signed-off-by: Brian DeHamer <[email protected]> * remove badges from README (actions#840) Signed-off-by: Brian DeHamer <[email protected]> --------- Signed-off-by: Brian DeHamer <[email protected]> Co-authored-by: Brian DeHamer <[email protected]>
kristentr
added a commit
to kristentr/attest-build-provenance
that referenced
this pull request
Mar 9, 2026
* prepare v4 release (actions#835) Signed-off-by: Brian DeHamer <[email protected]> * update RELEASE.md docs (actions#836) Signed-off-by: Brian DeHamer <[email protected]> * bump actions/attest from 4.0.0 to 4.1.0 (actions#838) Signed-off-by: Brian DeHamer <[email protected]> * remove prober workflows (actions#837) Signed-off-by: Brian DeHamer <[email protected]> * Kristentr patch 1 (#24) * Add CodeQL analysis workflow configuration * Add CodeQL analysis workflow configuration * prepare v4 release (actions#835) Signed-off-by: Brian DeHamer <[email protected]> * update RELEASE.md docs (actions#836) Signed-off-by: Brian DeHamer <[email protected]> * bump actions/attest from 4.0.0 to 4.1.0 (actions#838) Signed-off-by: Brian DeHamer <[email protected]> * remove prober workflows (actions#837) Signed-off-by: Brian DeHamer <[email protected]> * Add commands to create and update actions-main branch Signed-off-by: Kristen T. Tran <[email protected]> --------- Signed-off-by: Brian DeHamer <[email protected]> Signed-off-by: Kristen T. Tran <[email protected]> Co-authored-by: Brian DeHamer <[email protected]> * remove badges from README (actions#840) Signed-off-by: Brian DeHamer <[email protected]> * Add ESLint workflow for code analysis This workflow runs ESLint to analyze JavaScript code and uploads the results in SARIF format. * merge commit updates (#30) * prepare v4 release (actions#835) Signed-off-by: Brian DeHamer <[email protected]> * update RELEASE.md docs (actions#836) Signed-off-by: Brian DeHamer <[email protected]> * bump actions/attest from 4.0.0 to 4.1.0 (actions#838) Signed-off-by: Brian DeHamer <[email protected]> * remove prober workflows (actions#837) Signed-off-by: Brian DeHamer <[email protected]> * remove badges from README (actions#840) Signed-off-by: Brian DeHamer <[email protected]> --------- Signed-off-by: Brian DeHamer <[email protected]> Co-authored-by: Brian DeHamer <[email protected]> * Add CodeQL analysis workflow configuration (#33) --------- Signed-off-by: Brian DeHamer <[email protected]> Signed-off-by: Kristen T. Tran <[email protected]> Co-authored-by: Brian DeHamer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
action.ymlso that this action is now simply a pass-through toactions/attest. Theactions/attestaction now exposes all of the capabilities previously spread acrossactions/attest-build-provenanceandactions/attest-sbom.The major version bump here reflects the fact that the underlying implementation has fundamentally changed, but this should be backward-compatible for anyone using v3.x of this action.