Skip to content

Conversation

@foyerunix
Copy link

Hello,

This is basically an alternative implementation of #3575 taking into account the points raised by @nikola-jokic.

It improves upon it by:

Please note that I had to move the namespace where we create the autoscalinglisteners from the namespace where we run the controller to the namespace where we run the runners. Without this change, the autoscalinglisteners cannot be owned by their respective AutoscalingRunnerSet. If this is incorrect, please advise on the alternative approach so I can rework my PR accordingly.

It is running in my environment with no issues so far.

Best Regards.

@kahirokunn
Copy link
Contributor

duplicates: #3575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants