Skip to content

Exclude label prefix propagation#3607

Merged
nikola-jokic merged 1 commit into
masterfrom
nikola-jokic/label-propagation
Jun 21, 2024
Merged

Exclude label prefix propagation#3607
nikola-jokic merged 1 commit into
masterfrom
nikola-jokic/label-propagation

Conversation

@nikola-jokic
Copy link
Copy Markdown
Collaborator

@nikola-jokic nikola-jokic commented Jun 20, 2024

Propagating labels through internal resources managed by ARC can cause issues when ARC is used in combination with other tools, such as ArgoCD. This change introduces new flag on the controller that accepts the list of label prefixes that shouldn't be propagated to internal resources.

The reason we choose to opt out of labels instead of opt in to the label propagation behavior is due to several reasons:

  1. If cluster policies are configured to ensure every resource has a particular label, then propagating labels is a requirement
  2. If you are applying specific labels in order to easily manage resources, you should be able to inspect sub-resources based on that label.
  3. If you have cluster policies to propagate labels, and you want to use systems similar to Argo, that use resource tracking and act on it based on label, you should have a way to opt out of propagating specific labels.

Turning on/off label propagation would not solve the issue if you have cluster policies and you are managing your cluster with Argo. So this more granular approach ensures both scenarios are covered.

The resource builder component is instantiated with the ruleset, and will ignore labels that match the prefix configured.

Fixes #3533

@nikola-jokic nikola-jokic added the gha-runner-scale-set Related to the gha-runner-scale-set mode label Jun 20, 2024
Copy link
Copy Markdown
Member

@Link- Link- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending updating the PR description to include the reasoning for why we adopted this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gha-runner-scale-set Related to the gha-runner-scale-set mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue running 0.9.2. Listener crash restart loop when running inside ArgoCD

2 participants