Skip to content

Conversation

@nikola-jokic
Copy link
Collaborator

Previously, the status code was not checked on fetchAccessToken.

This PR aims to add a check for the endpoint described here.

Fixes #3565

@nikola-jokic nikola-jokic added the gha-runner-scale-set Related to the gha-runner-scale-set mode label Jun 3, 2024
@nikola-jokic nikola-jokic requested review from a team, mumoshu, rentziass and toast-gear as code owners June 3, 2024 13:42
@kahirokunn
Copy link
Contributor

LGTM

@nikola-jokic nikola-jokic merged commit b2c6992 into master Jun 21, 2024
@nikola-jokic nikola-jokic deleted the nikola-jokic/check-access-token-resp-code branch June 21, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gha-runner-scale-set Related to the gha-runner-scale-set mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading logs when blocked by IP allow list, does not show failure when requesting access token

4 participants