Remove finalizers in one pass to speed up cleanups AutoscalingRunnerSet #3536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-jokic
added
the
gha-runner-scale-set
nikola-jokic
requested review from
a team,
mumoshu,
rentziass and
toast-gear
as code owners
rentziass
approved these changes
May 24, 2024
This was referenced May 30, 2024
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you create a faulty autoscaling runner set, for example token is not correct, the cleanup will be very slow.
This PR removes the requeue (probably many events are raised causing latency, I'm not sure), so autoscaling runner set, and dependent resources can be removed much more quickly.
Fixes: #3512
Fixes: #3497