Skip to content

Conversation

@wherka-ama
Copy link
Contributor

@wherka-ama wherka-ama commented Oct 2, 2023

Add ability to add custom labels to the controller pods.

Fixes #2951

@wherka-ama
Copy link
Contributor Author

/fixes #2951

# Declare variables to be passed into your templates.
labels: {}

podTemplateLabels: {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this below the podAnnotations and also name it podLabels?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Thanks a lot @nikola-jokic !

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll run some tests just to make sure nothing breaks, but looks good to me! Thank you for your contribution!

@nikola-jokic nikola-jokic changed the title Possible implementation for Issue #2951 Allow custom labels to be specified for controller pods Oct 5, 2023
@nikola-jokic nikola-jokic added gha-runner-scale-set Related to the gha-runner-scale-set mode needs testing Requires the e2e tests to pass and/or manual tests to verify labels Oct 5, 2023
Copy link
Collaborator

@nikola-jokic nikola-jokic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@nikola-jokic nikola-jokic removed the needs testing Requires the e2e tests to pass and/or manual tests to verify label Oct 6, 2023
@nikola-jokic nikola-jokic merged commit ce80adb into actions:master Oct 6, 2023
@nikola-jokic nikola-jokic mentioned this pull request Oct 9, 2023
unpollito pushed a commit to DistruApp/actions-runner-controller that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gha-runner-scale-set Related to the gha-runner-scale-set mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gha-runner-scale-set-controller: supporting the custom labels on the pod template level

2 participants