-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Allow custom labels to be specified for controller pods #2952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/fixes #2951 |
| # Declare variables to be passed into your templates. | ||
| labels: {} | ||
|
|
||
| podTemplateLabels: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this below the podAnnotations and also name it podLabels?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Thanks a lot @nikola-jokic !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll run some tests just to make sure nothing breaks, but looks good to me! Thank you for your contribution!
nikola-jokic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Co-authored-by: Waldek Herka <[email protected]>
Add ability to add custom labels to the controller pods.
Fixes #2951