Runner Template does not support pod resources (k8s 1.32+)

[AngellusMortis]

Checks

• I've already read https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/troubleshooting-actions-runner-controller-errors and I'm sure my issue is not covered in the troubleshooting guide.
• I am using charts that are officially provided

Controller Version

0.10.1

Deployment Method

Helm

Checks

• This isn't a question or user support case (For Q&A and community support, go to Discussions).
• I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes

To Reproduce

1. Add values for `template.spec.resources` in the gha-runner-scale-set Helm chart values

Describe the bug

Kubernetes 1.32 adds the ability to set resource limits on the pod level, the CRD definition for AutoscalingRunnerSet does not allow this. Doing so results in

failed to create typed patch object (arc-runners/cicd-pipelines-dev; actions.github.com/v1alpha1, Kind=AutoscalingRunnerSet): .spec.template.spec.resources: field not declared in schema

Describe the expected behavior

AutoscalingRunnerSet should support pod level resource limits

Additional Context

template:
  spec:
    resources:
      requests:
        cpu: "2000m"
        memory: "1000Mi"
      limits:
        cpu: "2000m"
        memory: "8000Mi"

Controller Logs

failed to create typed patch object (arc-runners/cicd-pipelines-dev; actions.github.com/v1alpha1, Kind=AutoscalingRunnerSet): .spec.template.spec.resources: field not declared in schema

Runner Pod Logs

failed to create typed patch object (arc-runners/cicd-pipelines-dev; actions.github.com/v1alpha1, Kind=AutoscalingRunnerSet): .spec.template.spec.resources: field not declared in schema

[github-actions]

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

[FearlessHyena]

Just wanted to check if this has been released and if anyone has gotten this to work?

I'm using the latest v0.11.0 and tried setting the requests for CPU/Memory explicitly but it doesn't seem to be working and GKE still reports the CPU/Memory requested as 0

template:
  spec:
    resources:
      requests:
        cpu: "700m"
        memory: "2.3G"

(I'm using k8s 1.32 btw)

[FearlessHyena]

@nikola-jokic
I've tested this multiple times but this doesn't seem to work. Can we reopen this or can someone else verify how to get this
to work?

[AngellusMortis]

Yeah, it seems like the values file is accepting the resources on the spec object, but it is not being passed onto the actual pods.

        template:
          spec:
            resources:
              requests:
                cpu: "1000m"
                memory: "1000Mi"
              limits:
                cpu: "2000m"
                memory: "8000Mi"

$ kubectl -n arc-runners get pod cicd-pipelines-x2bqb-runner-48pn2 -o yaml | yq .spec.resources
null

[FearlessHyena]

Thanks for checking! I'm seeing the same behavior so we need to reopen this issue

[AngellusMortis]

Made #4034 since this ticket has not been reopened yet.

[AngellusMortis]

Whatever your issue is, it is not related to this one. You are defining resources on the container level, not the pod level. This is specifically about resources on a pod level.

template:
  spec:
    nodeSelector:
      nodepool-type: arc-runner-nodepool-02
      deployment-type: deploy
    topologySpreadConstraints:
      - maxSkew: 4
        topologyKey: "kubernetes.io/hostname"
        whenUnsatisfiable: ScheduleAnyway
        labelSelector:
          matchLabels:
            app.kubernetes.io/name: arc-runner-set-02
    containers:
    - name: runner
      resources:  # resources on the container
        requests:
          cpu: "1"
          memory: "4Gi"
        limits:
          cpu: "2"
          memory: "7Gi"

Pod level resources instead would be:

template:
  spec:
    nodeSelector:
      nodepool-type: arc-runner-nodepool-02
      deployment-type: deploy
    topologySpreadConstraints:
      - maxSkew: 4
        topologyKey: "kubernetes.io/hostname"
        whenUnsatisfiable: ScheduleAnyway
        labelSelector:
          matchLabels:
            app.kubernetes.io/name: arc-runner-set-02
    resources:  # resources on the pod
      requests:
        cpu: "1"
        memory: "4Gi"
      limits:
        cpu: "2"
        memory: "7Gi"
    containers:
    - name: runner

[mcdermg]

Seems neither level is currently working but will open a separate issue for the container level resource issue