Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

Action erroniously passing and showing duplicate lints with --all-targets enabled #1

@yaahc

Description

@yaahc

I noticed theres a big fat WIP on this repo so I'm not sure you're interested in bug reports on this action yet but incase you are I figured I'd file this one.

I tried testing out the new clippy action in this PR. It worked in so far as it showed the nice clippy warnings with the full output of the warning in the PR and it took minimal work to setup, which is fantastic 👍

The problem is that first of all, it showed as passing when clippy (or maybe just the action running clippy?) exited with a 101 code. Second, when --all-targets was enabled it showed the lints twice. Now I know that the --all-targets thing is reproducible outside of actions-rs so its not actually a bug with your code, so this second bit is probably more of a feature request than a bug report, but it would be nice if it filtered out identical error msgs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions