Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

feat: adds support for ignores#221

Open
moliva wants to merge 11 commits intoactions-rs:masterfrom
moliva:master
Open

feat: adds support for ignores#221
moliva wants to merge 11 commits intoactions-rs:masterfrom
moliva:master

Conversation

@moliva
Copy link
Copy Markdown

@moliva moliva commented May 10, 2022

  • Adds support for cargo audit --ignore
  • Configurable input by comma separated input string as GH Actions does not support sequences as inputs
  • Bumps version to 1.3.2
  • Adds .nvrm to Node v16 to avoid issue with envelope routines unsupported

Usage example:

jobs:
  security_audit:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v1
      - uses: moliva/audit-check@v1.3.2
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          ignore: "RUSTSEC-2020-0159, RUSTSEC-2020-0071"

This version can be used FTTB with this option installed: moliva/audit-check@v1.3.2 .

@buehler
Copy link
Copy Markdown

buehler commented Jun 13, 2022

This would be a blast!
There are several use cases where we'd like to ignore some smaller reported issues.
An example is the chrono package which has a segmentation fault issue for a specific Linux distribution. But chrono is used in many packages as dependency and is not yet updated.

@maujim
Copy link
Copy Markdown

maujim commented Jun 14, 2022

Would it be possible to support the ignore syntax mentioned in #223?

@moliva
Copy link
Copy Markdown
Author

moliva commented Jun 17, 2022

Would it be possible to support the ignore syntax mentioned in #223?

The original implementation used this array/list format, but it seems GitHub Actions input doesn't support anything but strings (at least up to this point in time).

@moliva moliva mentioned this pull request Jun 17, 2022
3 tasks
@djmitche
Copy link
Copy Markdown

djmitche commented Jul 4, 2022

Hi @svartalf -- any chance you could take a look at this PR?

@matschaffer
Copy link
Copy Markdown

@moliva I think you need to add the new input to https://github.com/actions-rs/audit-check/blob/master/action.yml#L8 as well

Looks like this should probably work

inputs:
  token:
    description: GitHub Actions token
    required: true
  ignore:
    description: Comma-separated list of advisory ids to ignore
    required: false

@0xAlcibiades
Copy link
Copy Markdown

This would be really useful re: #223 - any thing blocking this from getting merged?

@djmitche
Copy link
Copy Markdown

This repo seems pretty quiet. You all are welcome to depend on https://github.com/GothenburgBitFactory/audit-check in the interim, or of course you can fork the action yourself.

@matschaffer thanks - I can add that on the fork.

@matschaffer
Copy link
Copy Markdown

@moliva
Copy link
Copy Markdown
Author

moliva commented Aug 4, 2022

@moliva I think you need to add the new input to https://github.com/actions-rs/audit-check/blob/master/action.yml#L8 as well

Looks like this should probably work

inputs:
  token:
    description: GitHub Actions token
    required: true
  ignore:
    description: Comma-separated list of advisory ids to ignore
    required: false

Thanks @matschaffer , I wasn't aware of that file. This PR by itself is already working for me, I've been using it mostly because of chrono's potential issues, see here.

@djmitche
Copy link
Copy Markdown

djmitche commented Aug 6, 2022

So it turns out that .cargo/audit.toml can be used to ignore things, too -- I just had it in the wrong directory (fix in GothenburgBitFactory/taskwarrior#2903). So the fork probably isn't necessary!

@matschaffer
Copy link
Copy Markdown

Ooooh! nice find!

@pinkforest
Copy link
Copy Markdown

There were a lot of outdated dependencies which have been brought relatively up to date at:

We've forked to rustsec/audit-check

Have also forked actions-rs/core to rinse-repeat/audit-rs-core

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

7 participants