Skip to content

Weaken validation #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 29, 2025
Merged

Weaken validation #30

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
62bbf3e
fix: use non strict schema to allow some undefined behavior
ChristopherHX Nov 7, 2024
4fed339
Update workflow.go
ChristopherHX Nov 7, 2024
b253c5d
Update workflow.go
ChristopherHX Nov 7, 2024
be575d3
Update pkg/model/workflow.go
ChristopherHX Nov 8, 2024
78b115c
Merge branch 'master' into weaken-validation
ChristopherHX Dec 29, 2024
e5f3216
Merge branch 'main' of https://github.com/actions-oss/act-cli into we…
ChristopherHX Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/model/workflow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package model

import (
"errors"
"fmt"
"io"
"reflect"
Expand Down Expand Up @@ -70,10 +71,10 @@ func (w *Workflow) OnEvent(event string) interface{} {
func (w *Workflow) UnmarshalYAML(node *yaml.Node) error {
// Validate the schema before deserializing it into our model
if err := (&schema.Node{
Definition: "workflow-root-strict",
Definition: "workflow-root",
Schema: schema.GetWorkflowSchema(),
}).UnmarshalYAML(node); err != nil {
return err
return errors.Join(err, fmt.Errorf("Actions YAML Schema Validation Error detected:\nFor more information, see: https://nektosact.com/usage/schema.html"))
}
type WorkflowDefault Workflow
return node.Decode((*WorkflowDefault)(w))
Expand Down
Loading