Add ability to patch RSTB via commandline #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When more than one argument is supplied for RSTB editing, the program will assume the 2nd argument is the path to the romFS folder and use that to overwrite the input RSTB with a patched one. If a third argument is supplied, it will assume the 3rd path is the output RSTB and save it there instead of overwriting. To make this work without further user input, I had to add bools for whether or not to show messagebox prompts to the RSTB saving and updating functions. This way, the program assumes that you always want to compress the RSTB and doesn't show the results messagebox when updating via commandline. One issue I've noticed is that occasionally there is a popup about the collection being modified while in a for loop. I assume this is some kind of race condition relating to updating being an async function, but I'm not sure.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some changes I made so that I could update my RSTB via heaventool with one click, which is handy for adding the RSTB patching process to batch files.
How It's Implemented
UpdateFromModdedRomFs_Clickprocedure and made public so it can be reused in Program.cs for commandline arguments.To make this work without further user input, I had to add bools for whether or not to show messagebox prompts to the RSTB saving and updating functions. This way, the program assumes that you always want to compress the RSTB and doesn't show the results messagebox when updating via commandline.
Possible Issues
One issue I've noticed is that occasionally there is a popup about the collection being modified while in a for loop. I assume this is some kind of race condition relating to the RSTB update function being asynchronous, but I'm not sure.