update dns_doapi #5158
Merged
update dns_doapi #5158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome |
Contributor
Author
|
Please read the message above why the tests are failing, i have read the guide |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we are moving our API endpoint to a different subdomain (the old one will continue to work for now),
dns_do does not exist anymore so I have removed it from the text.
The tests are failing due to the acmetestXyzRandomName. subdomain that is being used in the tests, the api of ours currently only allows subdomains starting with "_acme-challenge.", why is this a requirement now? I can see nowhere in the RFC 8555 that subdomains not starting with "_acme-challenge." are allowed.