Skip to content

Conversation

@zearan
Copy link
Contributor

@zearan zearan commented Jul 26, 2023

I was not getting all domains that are managed within my PLESK accounts when I was using the script. I had to merge the list of domains that is getting pulled via "<packet><webspace>" with a list of domains pulled via "<packet><site>". To ease debugging, I had to adopt the related debug messages and fixed the 'hacked output' in the meantime.

@github-actions
Copy link

Welcome
Please make sure you're read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨

ShellCheck tests have brought up a couple of issues, that I was not aware of needed to be taken care. This should fix the tests.
@zearan
Copy link
Contributor Author

zearan commented Jul 29, 2023

I have added changes that should fix the failed workflow tests.

@Neilpang Neilpang merged commit b384a24 into acmesh-official:dev Jul 30, 2023
@zearan zearan deleted the patch-1 branch July 31, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants