Skip to content

fix: support shakapacker v8 #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
G-Rath merged 1 commit into from
Jul 12, 2024
Merged

fix: support shakapacker v8 #546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions variants/frontend-base/template.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,11 @@
remove_dir "app/assets/stylesheets"
remove_dir "app/assets/images"

# this will create a package.json for us
run "rails shakapacker:install"
# create a basic package.json which explicitly sets our preferred package manager
# for external tooling; shakapacker:install will add a _lot_ more for us later
File.write("./package.json", JSON.generate({ "packageManager" => "[email protected]" }))

# explicitly set our preferred package manager for external tooling
update_package_json do |package_json|
package_json["packageManager"] = "[email protected]"
end
run "rails shakapacker:install"

# this is added by shakapacker:install, but we've already got one (with some extra tags)
# in our template, so remove theirs otherwise the app will error when rendering this
Expand All @@ -34,7 +32,6 @@

gsub_file! "config/shakapacker.yml", "cache_path: tmp/shakapacker", "cache_path: tmp/cache/shakapacker"
gsub_file! "config/shakapacker.yml", "source_path: app/javascript", "source_path: app/frontend"
gsub_file! "config/shakapacker.yml", "ensure_consistent_versioning: false", "ensure_consistent_versioning: true"

old_shakapacker_test_compile_snippet = <<~EO_OLD
test:
Expand Down