fix: check for NoMethodError instead of NotImplementedError#545
Merged
Conversation
G-Rath
requested review from
JacobBriggsAckama,
brooke-m,
eoinkelly,
halles,
hopkincame,
joshmcarthur,
lukeify and
robotdana
G-Rath
force-pushed
the
update-pundit
branch
2 times, most recently
from
4103ea7 to
0b8d1c3
Compare
JacobBriggsAckama
approved these changes
May 10, 2024
Contributor
Author
|
This is blocked by #546, which is blocked by this PR |
Contributor
|
lets do this now, and revisit when some variant of https://bugs.ruby-lang.org/issues/18915 lands |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pundit have recently changed to using
NoMethodError, which breaks our spec - the main benefit of this change is that the new error extends fromStandardErrorso in theory is easier to catch; however, it seems the community is divided as aside from the different superclass the existing error is more accurate sinceNoMethodErroris meant to be thrown when the class does notrespond_to?the method in question and that is not true.I personally would like to keep using
NotImplementedErrorthough I'm happy to change if someone does prove a real-world situation where it's more burdson to catch (or that our error monitoring won't catch it), but I feel that should be a separate conversation - so this PR is changing it back to maintain our current status quo until such time that we do decide to change.