feat: switch to using package_json for interacting with package.json#466
Merged
feat: switch to using package_json for interacting with package.json#466
package_json for interacting with package.json#466Conversation
G-Rath
force-pushed
the
use-package_json
branch
4 times, most recently
from
87d0b8f to
994e8b0
Compare
3 tasks
G-Rath
force-pushed
the
use-package_json
branch
15 times, most recently
from
d82c432 to
e507562
Compare
lukeify
reviewed
Aug 24, 2023
G-Rath
force-pushed
the
use-package_json
branch
9 times, most recently
from
2e394b9 to
bf17a19
Compare
G-Rath
force-pushed
the
use-package_json
branch
from
93a626e to
9779155
Compare
Contributor
Author
|
Bun tests are currently broken because of oven-sh/bun#8406 / oven-sh/bun#9135 |
3 tasks
This was referenced May 18, 2024
Contributor
|
I think we should be opinionated about which JS package manager we support. It's cool we can support many but for our own sanity, baking one into this repo makes sense to me. |
Contributor
Author
|
Discussed this in our guild meeting today: we're going to land it as-is so that it's in the history, and immediately follow up with switching to using That's not to say we won't potentially explore and switch to another package manager in the future, but doing so would be in response to a wider choice rather than Rails specific, which is what this PR is meant to enable |
eoinkelly
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to support all of the major javascript package managers by relying on the
package_jsongem to handle running and generating commands for a particular package manager.Currently I'm making our template actually agnostic and have setup to test that is the case by running against the major package managers + Yarn PnP, though I expect after landing this we'll decide on a single package manager to use going forward and remove code that is needed for the other package managers.