Be able to parse the netmask format#112
Merged
achanda merged 1 commit intoachanda:masterfrom Jan 4, 2020
vorner:netmask-parse
Merged
Be able to parse the netmask format#112achanda merged 1 commit intoachanda:masterfrom vorner:netmask-parse
achanda merged 1 commit intoachanda:masterfrom
vorner:netmask-parse
Conversation
Allow accepting the netmask format, eg 192.168.1.0/255.255.255.0, in addition to the more modern /24 prefix version. Adding support for IPv4 only, as IPv6 never actually used that format in practice. Closes #107.
Owner
|
Sorry for being late on this, I was on vacation. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow accepting the netmask format, eg 192.168.1.0/255.255.255.0, in
addition to the more modern /24 prefix version.
Adding support for IPv4 only, as IPv6 never actually used that format in
practice.
Closes #107.