Markers - Allow placing quick number markers #11019
Draft
+78
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rautamiekka
suggested changes
Oct 15, 2025
Comment on lines
+49
to
+51
| if (GVAR(quickNumberMarks) == 0) exitWith {}; | ||
| if (!cba_events_alt) exitWith {}; // not available before mission start | ||
| if (_marker != "") exitWith {}; // editing an existing marker |
Contributor
There was a problem hiding this comment.
Suggested change
| if (GVAR(quickNumberMarks) == 0) exitWith {}; | |
| if (!cba_events_alt) exitWith {}; // not available before mission start | |
| if (_marker != "") exitWith {}; // editing an existing marker | |
| if (!cba_events_alt) exitWith {}; // not available before mission start | |
| if (GVAR(quickNumberMarks) isEqualTo 0) exitWith {}; | |
| if (_marker isNotEqualTo "") exitWith {}; // editing an existing marker |
| if (_marker != "") exitWith {}; // editing an existing marker | ||
|
|
||
| private _description = _display displayCtrl IDC_INSERT_MARKER; | ||
| private _number = if ((GVAR(quickNumberMarks) == 1) || {currentChannel != 1}) then { |
Contributor
There was a problem hiding this comment.
Suggested change
| private _number = if ((GVAR(quickNumberMarks) == 1) || {currentChannel != 1}) then { | |
| private _number = if ((GVAR(quickNumberMarks) isEqualTo 1) || {currentChannel isNotEqualTo 1}) then { |
| GVAR(currentMarkerConfigName) = QGVAR(textOnly); | ||
| } else { | ||
| // try to update our local marker index when placing a text-only marker with a number | ||
| if ((GVAR(quickNumberMarks) == 2) && {currentChannel == 1}) exitWith {}; |
Contributor
There was a problem hiding this comment.
Suggested change
| if ((GVAR(quickNumberMarks) == 2) && {currentChannel == 1}) exitWith {}; | |
| if ((GVAR(quickNumberMarks) isEqualTo 2) && {currentChannel isEqualTo 1}) exitWith {}; |
| } else { | ||
| // try to update our local marker index when placing a text-only marker with a number | ||
| if ((GVAR(quickNumberMarks) == 2) && {currentChannel == 1}) exitWith {}; | ||
| if ((markerType _newestMarker) != QGVAR(textOnly)) exitWith {}; |
Contributor
There was a problem hiding this comment.
Suggested change
| if ((markerType _newestMarker) != QGVAR(textOnly)) exitWith {}; | |
| if ((markerType _newestMarker) isNotEqualTo QGVAR(textOnly)) exitWith {}; |
Comment on lines
+82
to
+87
| private _count = count _text; | ||
| private _isNumber = true; | ||
| if (_count > 6) exitWith {}; | ||
| for "_i" from 0 to (_count - 1) do { | ||
| if !((_text select [_i, 1]) in "0123456789") exitWith { _isNumber = false; }; | ||
| }; |
Contributor
There was a problem hiding this comment.
Suggested change
| private _count = count _text; | |
| private _isNumber = true; | |
| if (_count > 6) exitWith {}; | |
| for "_i" from 0 to (_count - 1) do { | |
| if !((_text select [_i, 1]) in "0123456789") exitWith { _isNumber = false; }; | |
| }; | |
| if (_count > 6) exitWith {}; | |
| private _isNumber = _text regexMatch ".*?[0-9].*+/o"; |
Whether the /o part, meaning "optimize", is faster or slower, has to be tested.
Co-authored-by: Jouni Järvinen <[email protected]>
Co-authored-by: Jouni Järvinen <[email protected]>
Co-authored-by: Jouni Järvinen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows quick numbering by holding alt when placing a marker
no dialog, just get a incrementally numbered mark