Skip to content

NOISSUE - Disconnect client on Failed Authz Publish #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arvindh123 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

NOISSUE - Disconnect client on Failed Authz Publish #101

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6be5ca6
try to disconnect on failed authz publish
arvindh123 Jun 23, 2025
9b621bd
update logic to disconnect for authz failed publish
arvindh123 Aug 12, 2025
4b26856
update disconnect control packet
arvindh123 Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions pkg/session/stream.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,29 @@ func stream(ctx context.Context, dir Direction, r, w net.Conn, h Handler, preIc,
switch dir {
case Up:
if err = authorize(ctx, pkt, h); err != nil {
if pub, ok := pkt.(*packets.PublishPacket); ok {
switch pub.Qos {
case 0:
Copy link
Contributor Author

@arvindh123 arvindh123 Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this approach, If authn and authz fails and if QoS is greater than 0 , then MQTT Client will keep on retrying.

Best approach is disconnect the MQTT Client if authn or authz fails

pkt = packets.NewControlPacket(packets.Disconnect).(*packets.DisconnectPacket)
if wErr := pkt.Write(w); wErr != nil {
err = errors.Join(err, wErr)
}
case 1:
puback := packets.NewControlPacket(packets.Puback).(*packets.PubackPacket)
puback.MessageID = pub.MessageID
if wErr := puback.Write(w); wErr != nil {
err = errors.Join(err, wErr)
}

case 2:
pubrec := packets.NewControlPacket(packets.Pubrec).(*packets.PubrecPacket)
pubrec.MessageID = pub.MessageID

if wErr := pubrec.Write(w); wErr != nil {
err = errors.Join(err, wErr)
}
}
}
errs <- wrap(ctx, err, dir)
return
}
Expand Down
Loading