Open
Conversation
codeadict
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR:
The main use case for providing runtime config is to override
local_directoryoption when using Elixir releases:The above is a method to use patched version of
@absinthe/socketdependency which fixes the missing headers bug (see absinthe-graphql/absinthe-socket#67)As far as I know this cannot be achieved using compile-time configuration, because
Application.app_dir(:my_app)is not available at that time. Besides, compile-time configuration didn't work anyway - it was inducing a compilation error.assetsoption from plug'sinit/1type specification, because it was not used there.