Add support for passing a CSP nonce through to the templates#289
Open
jschniper wants to merge 1 commit intoabsinthe-graphql:mainfrom
Open
Add support for passing a CSP nonce through to the templates#289jschniper wants to merge 1 commit intoabsinthe-graphql:mainfrom
jschniper wants to merge 1 commit intoabsinthe-graphql:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes allow you to pass a
csp_nonce_assign_keyas an option into the plug and it uses that to pull a nonce from theconn.assignsto add a nonce attribute to the script and link tags.This is my first hack at it but it seems to resolve the CSP related errors that I was experiencing. Open to suggestions for improvement.
One note: I'm experiencing a JS error on the advanced GraphiQL interface but I'm also experiencing the same error when I run against the current main branch in this repo. Not exactly sure what is going on there but it doesn't seem as though my changes are the cause.