feat: add description support for operations and fragments#1404
Open
jwaldrip wants to merge 1 commit intoabsinthe-graphql:mainfrom
Open
feat: add description support for operations and fragments#1404jwaldrip wants to merge 1 commit intoabsinthe-graphql:mainfrom
jwaldrip wants to merge 1 commit intoabsinthe-graphql:mainfrom
Conversation
Implements the GraphQL September 2025 specification feature that allows descriptions on executable definitions (operations and fragments). Changes: - Add `description` field to Blueprint.Document.Operation struct - Add `description` field to Blueprint.Document.Fragment.Named struct - Add `description` field to Language.OperationDefinition struct - Add `description` field to Language.Fragment struct - Update parser to accept descriptions before operations and fragments - Update Blueprint.Draft conversion to preserve descriptions - Update SDL rendering to output descriptions for operations/fragments - Add comprehensive tests for the new functionality Specification: https://spec.graphql.org/September2025/#sec-Descriptions Reference: RFC absinthe-graphql#1170 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
56f8551 to
65ce8cc
Compare
Contributor
Author
|
Hey team — just checking in on this one. Any thoughts or concerns on adding description support for operations and fragments? Happy to make adjustments if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This implements the Document Descriptions feature from the GraphQL September 2025 specification, allowing descriptions to be added to operations and fragments in GraphQL documents.
Test plan
🤖 Generated with Claude Code