feat: Support disabling field/query suggestions on error#1393
Open
rschef wants to merge 1 commit intoabsinthe-graphql:mainfrom
Open
feat: Support disabling field/query suggestions on error#1393rschef wants to merge 1 commit intoabsinthe-graphql:mainfrom
rschef wants to merge 1 commit intoabsinthe-graphql:mainfrom
Conversation
Member
|
I think a boolean here would be preferable, but curious as to what other folks think. cc: @absinthe-graphql/core |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabling schema introspection in production is common in order to reduce the API’s attack surface, but currently it's not possible to disable field/query suggestions on Absinthe, which can also be used to gain insights into the GraphQL schema.
The proposed solution is to add a
maximum_number_of_suggestionsoption and allow disabling suggestions by settingmaximum_number_of_suggestions: 0as option.Please let me know if you prefer a boolean field (e.g.
disable_suggestion_on_error: true) or have other solutions in mind.Thank you!