feat: Make task implementation for async configurable#1349
Open
drtheuns wants to merge 3 commits intoabsinthe-graphql:mainfrom
Open
feat: Make task implementation for async configurable#1349drtheuns wants to merge 3 commits intoabsinthe-graphql:mainfrom
drtheuns wants to merge 3 commits intoabsinthe-graphql:mainfrom
Conversation
benwilson512
requested changes
Dec 8, 2024
Contributor
benwilson512
left a comment
benwilson512
left a comment
There was a problem hiding this comment.
I think this is a fine idea but we definitely want this to be compile time.
benwilson512
reviewed
Dec 9, 2024
Author
|
The first time Absinthe compiles (e.g. on CI) it will give a warning about the configured module not existing (yet). I haven't tried but it might be possible to get around this with |
|
Hi. Is there anything more that I need to do to get this MR to completion? |
cschiewek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projects that don't use open-telemetry or with more complex process propagation requirements can now implement it themselves by configuring the
Taskmodule to use.