feat: Eliminate bare atom identifiers#1198
Open
maartenvanvliet wants to merge 4 commits intoabsinthe-graphql:mainfrom
Open
feat: Eliminate bare atom identifiers#1198maartenvanvliet wants to merge 4 commits intoabsinthe-graphql:mainfrom
maartenvanvliet wants to merge 4 commits intoabsinthe-graphql:mainfrom
Conversation
kdawgwilk
reviewed
Sep 19, 2022
lib/absinthe/phase/schema/validation/object_must_implement_interfaces.ex
Outdated
Show resolved
Hide resolved
…erfaces.ex Co-authored-by: Kaden Wilkinson <7799267+kdawgwilk@users.noreply.github.com>
cschiewek
changed the title
Member
|
@maartenvanvliet I'd still like to check this shipped. Could you rebase against main when you have a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures the Macro schema's also use the TypeReference structs to refer to types in unions/interfaces/fields etc.
This makes the SDL and Macro schema's more in line with each other.
Fixes #783 and should also make it easier for string type identifiers alluded to in #439