Maite modules batch 7 #1319
Open
Maite modules batch 7 #1319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored all artifact processor functions to use a context object. Removed the 'bereal_preferences' artifact and made it a helper function with a flag to make sure it only runs once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor backupSettings and BeReal to use context parameter.
Refactored bereal_preferences from an artifact into a helper function. This change addresses an initialization issue where the artifact execution order was not guaranteed, which could result in global variables being used before they were set. The new function now uses a flag to ensure its logic runs only once on the first call, guaranteeing that globals are initialized safely
Tested both with an ios15 image and everything works fine