Update ilapfuncs.py - get_birthday fix #1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a birthday is added to a contact without a year, it is stored with the year 1604. These dates can cause an issue in Windows Python with the current function that is used to parse these dates. If one of these dates is found the addressBook.py artifact causes the error: "OSError: [Errno 22] Invalid argument" and completely fails to output any results. This change replaces datetime.utcfromtimestamp (which is also depreciated) with manually creating a Cocoa Epoch to avoid out of range date problems. The datetime.fromtimestamp function is also susceptible to this problem.