Improve --resync warning prompt for clarity and safer operation #3562
+147
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update refines the --resync user warning prompt to provide clearer, more accurate guidance on the behaviour and risks associated with performing a resynchronisation operation. Key improvements include: Explicitly explaining that --resync deletes the client’s local state database and rebuilds it entirely from the current OneDrive contents. Accurately describing possible outcomes, including overwrite scenarios, conflict-driven renames or duplications, increased upload/download activity, and potential Microsoft Graph API throttling (HTTP 429). Removing incorrect implications that local-only files may be deleted during --resync (they will instead be uploaded, unless destructive cleanup modes are explicitly used). Strengthening safety guidance by recommending: Maintaining a current backup of the sync_dir Running the same command with --dry-run before executing a real --resync Enabling use_recycle_bin so locally triggered online deletions are preserved Improved formatting and readability for terminal output. This change enhances user understanding, reduces the likelihood of accidental data loss, and aligns runtime messaging with the client’s actual synchronisation logic and documented behaviour.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
Owner
Author
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Repository owner
locked and limited conversation to collaborators
Dec 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update refines the --resync user warning prompt to provide clearer, more accurate guidance on the behaviour and risks associated with performing a resynchronisation operation.
Key improvements include:
Explicitly explaining that --resync deletes the client’s local state database and rebuilds it entirely from the current OneDrive contents.
Accurately describing possible outcomes, including overwrite scenarios, conflict-driven renames or duplications, increased upload/download activity, and potential Microsoft Graph API throttling (HTTP 429).
Removing incorrect implications that local-only files may be deleted during --resync (they will instead be uploaded, unless destructive cleanup modes are explicitly used).
Strengthening safety guidance by recommending:
Improved formatting and readability for terminal output.
This change enhances user understanding, reduces the likelihood of accidental data loss, and aligns runtime messaging with the client’s actual synchronisation logic and documented behaviour.