Skip to content

Implement FR #3416: Dotfiles in sync_list should be synced even when skip_dotfiles = "true" #3456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abraunegg merged 2 commits into from
Oct 4, 2025
Merged

Implement FR #3416: Dotfiles in sync_list should be synced even when skip_dotfiles = "true" #3456

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf79130
Implement FR #3416: Dotfiles in sync_list should be synced even when …
abraunegg Sep 30, 2025
f7a9faf
Merge branch 'master' into implement-feature-3416
abraunegg Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/sync.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5521,8 +5521,14 @@ class SyncEngine {
// Do we need to check skip dot files if configured
if (appConfig.getValueBool("skip_dotfiles")) {
if (isDotFile(localFilePath)) {
if (verboseLogging) {addLogEntry("Skipping item - .file or .folder: " ~ localFilePath, ["verbose"]);}
clientSideRuleExcludesPath = true;
if (!syncListConfigured) {
// 'sync_list' is not in use
if (verboseLogging) {addLogEntry("Skipping item - .file or .folder: " ~ localFilePath, ["verbose"]);}
clientSideRuleExcludesPath = true;
} else {
// 'sync_list' is in use - potentially skipping .file or .folder but it may be included via 'sync_list'
if (verboseLogging) {addLogEntry("Potentially skipping item - .file or .folder (sync_list inclusion check to be done): " ~ localFilePath, ["verbose"]);}
}
}
}
}
Expand Down
Loading