Skip to content

Fix issues #2810, #2813, #2822, #2829#2816

Merged
abraunegg merged 16 commits intomasterfrom
fix-issue-2810-2813
Sep 26, 2024
Merged

Fix issues #2810, #2813, #2822, #2829#2816
abraunegg merged 16 commits intomasterfrom
fix-issue-2810-2813

Conversation

@abraunegg
Copy link
Owner

@abraunegg abraunegg commented Sep 18, 2024

  • Add isValidUTCDateTime function to validate timestamp as received from OneDrive API to ensure it is valid
  • Use new function before attempting to call SysTime.fromISOExtString to ensure this call will be successful
  • If there is no timestamp in the JSON, set it to the system time
  • Add assertion when building an item from DB data, if this fails with bad timestamp data
  • Revert to v2.4.25 sqlite 'synchronous' configuration
  • Add new function (isValidUTF8) to check UTF-8 validity of a string before regex check
  • In a --resync scenario, if the file hash is the same, use the online timestamp
  • Ensure that the session URL data is a valid JSON response before use

These fixes all seem unrelated .. however these are the potential root causes for all the issue tickets:

* Add isValidUTCDateTime function to validate timestamp as received from OneDrive API to ensure it is valid
* Use new function before attempting to call SysTime.fromISOExtString to ensure this call will be successful
@abraunegg abraunegg added this to the v2.5.1 milestone Sep 18, 2024
* If there is no timestamp in the JSON, set it to the system time
* Add assertion when building an item from DB data
* Revert to v2.4.25 sqlite 'synchronous' configuration
* Add new function (isValidUTF8) to check UTF-8 validity of a string before regex check
* In a --resync scenario, if the file hash is the same, use the online timestamp
* Ensure that the session URL data is a valid JSON response before use
* add specific output as to why assertion occured
* Fix PR
Ensure a local time in UTC is being used if the JSON data has no date
* Ensure the DB is opened in the most threadsafe manner possible
* Add patch provided by @phlibi
* Align timestamp creation method with itemdb if element is missing
@abraunegg abraunegg merged commit 410ffe4 into master Sep 26, 2024
@abraunegg abraunegg deleted the fix-issue-2810-2813 branch September 26, 2024 21:03
@abraunegg
Copy link
Owner Author

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Repository owner locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.