Bug: Onedrive client updates modification time of local files being uploaded

[ecasselton]

Describe the bug

Using neovim to write to a file which has been uploaded to onedrive causes neovim to display the error

WARNING: The file has been changed since reading it!!!
Do you really want to write to it (y/n)?

I think this is because the onedrive client updates the modification time of the file.

Operating System Details

~ uname -a
Linux 6.12.12-1-lts #1 SMP PREEMPT_DYNAMIC Sat, 01 Feb 2025 18:47:29 +0000 x86_64 GNU/Linux

~ lsb_release -a
LSB Version:    n/a
Distributor ID: Arch
Description:    Arch Linux
Release:        rolling
Codename:       n/a

Client Installation Method

From Distribution Package

OneDrive Account Type

Personal

What is your OneDrive Application Version

onedrive v2.5.4

What is your OneDrive Application Configuration

Application version                          = onedrive v2.5.4
Compiled with                                = DMD 2109
Curl version                                 = libcurl/8.12.0 OpenSSL/3.4.0 zlib/1.3.1 brotli/1.1.0 zstd/1.5.6 libidn2/2.3.7 libpsl/0.21.5 libssh2/1.11.1 nghttp2/1.64.0 nghttp3/1.7.0
User Application Config path                 = $HOME/.config/onedrive
System Application Config path               = /etc/onedrive
Applicable Application 'config' location     = $HOME/.config/onedrive/config
Configuration file found in config location  = true - using 'config' file values to override application defaults
Applicable 'sync_list' location              = $HOME/config/onedrive/sync_list
Applicable 'items.sqlite3' location          = $HOME/.config/onedrive/items.sqlite3
Config option 'drive_id'                     =
Config option 'sync_dir'                     = ~/OneDrive
Config option 'enable_logging'               = false
Config option 'log_dir'                      = /var/log/onedrive
Config option 'disable_notifications'        = true
Config option 'skip_dir'                     = Programming/C#/*/bin|Programming/C#/*/obj
Config option 'skip_dir_strict_match'        = false
Config option 'skip_file'                    = ~*|.~*|*.tmp|*.swp|*.partial
Config option 'skip_dotfiles'                = true
Config option 'skip_symlinks'                = false
Config option 'monitor_interval'             = 300
Config option 'monitor_log_frequency'        = 12
Config option 'monitor_fullscan_frequency'   = 12
Config option 'read_only_auth_scope'         = false
Config option 'dry_run'                      = false
Config option 'upload_only'                  = false
Config option 'download_only'                = false
Config option 'local_first'                  = false
Config option 'check_nosync'                 = false
Config option 'check_nomount'                = false
Config option 'resync'                       = false
Config option 'resync_auth'                  = false
Config option 'cleanup_local_files'          = false
Config option 'classify_as_big_delete'       = 1000
Config option 'disable_upload_validation'    = false
Config option 'disable_download_validation'  = false
Config option 'bypass_data_preservation'     = false
Config option 'no_remote_delete'             = false
Config option 'remove_source_files'          = false
Config option 'sync_dir_permissions'         = 700
Config option 'sync_file_permissions'        = 600
Config option 'space_reservation'            = 52428800
Config option 'permanent_delete'             = false
Config option 'application_id'               = d50ca740-c83f-4d1b-b616-12c519384f0c
Config option 'azure_ad_endpoint'            =
Config option 'azure_tenant_id'              =
Config option 'user_agent'                   = ISV|abraunegg|OneDrive Client for Linux/v2.5.4
Config option 'force_http_11'                = false
Config option 'debug_https'                  = false
Config option 'rate_limit'                   = 0
Config option 'operation_timeout'            = 3600
Config option 'dns_timeout'                  = 60
Config option 'connect_timeout'              = 10
Config option 'data_timeout'                 = 60
Config option 'ip_protocol_version'          = 0
Config option 'threads'                      = 8
Config option 'max_curl_idle'                = 120
Environment var 'XDG_RUNTIME_DIR'            = false
Environment var 'DBUS_SESSION_BUS_ADDRESS'   = false
Config option 'notify_file_actions'          = false

Selective sync 'sync_list' configured        = false

Config option 'sync_business_shared_items'   = false

Config option 'webhook_enabled'              = false

What is your 'curl' version

curl 8.12.0 (x86_64-pc-linux-gnu) libcurl/8.12.0 OpenSSL/3.4.0 zlib/1.3.1 brotli/1.1.0 zstd/1.5.6 libidn2/2.3.7 libpsl/0.21.5 libssh2/1.11.1 nghttp2/1.64.0 nghttp3/1.7.0
Release-Date: 2025-02-05
Protocols: dict file ftp ftps gopher gophers http https imap imaps ipfs ipns mqtt pop3 pop3s rtsp scp sftp smb smbs smtp smtps telnet tftp ws wss
Features: alt-svc AsynchDNS brotli GSS-API HSTS HTTP2 HTTP3 HTTPS-proxy IDN IPv6 Kerberos Largefile libz NTLM PSL SPNEGO SSL threadsafe TLS-SRP UnixSockets zstd

Where is your 'sync_dir' located

Local

What are all your system 'mount points'

proc on /proc type proc (rw,nosuid,nodev,noexec,relatime)
sys on /sys type sysfs (rw,nosuid,nodev,noexec,relatime)
dev on /dev type devtmpfs (rw,nosuid,relatime,size=8010636k,nr_inodes=2002659,mode=755,inode64)
run on /run type tmpfs (rw,nosuid,nodev,relatime,mode=755,inode64)
efivarfs on /sys/firmware/efi/efivars type efivarfs (rw,nosuid,nodev,noexec,relatime)
/dev/nvme0n1p7 on / type ext4 (rw,relatime)
securityfs on /sys/kernel/security type securityfs (rw,nosuid,nodev,noexec,relatime)
tmpfs on /dev/shm type tmpfs (rw,nosuid,nodev,inode64)
devpts on /dev/pts type devpts (rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000)
cgroup2 on /sys/fs/cgroup type cgroup2 (rw,nosuid,nodev,noexec,relatime,nsdelegate,memory_recursiveprot)
pstore on /sys/fs/pstore type pstore (rw,nosuid,nodev,noexec,relatime)
bpf on /sys/fs/bpf type bpf (rw,nosuid,nodev,noexec,relatime,mode=700)
systemd-1 on /proc/sys/fs/binfmt_misc type autofs (rw,relatime,fd=41,pgrp=1,timeout=0,minproto=5,maxproto=5,direct,pipe_ino=10320)
mqueue on /dev/mqueue type mqueue (rw,nosuid,nodev,noexec,relatime)
hugetlbfs on /dev/hugepages type hugetlbfs (rw,nosuid,nodev,relatime,pagesize=2M)
debugfs on /sys/kernel/debug type debugfs (rw,nosuid,nodev,noexec,relatime)
tracefs on /sys/kernel/tracing type tracefs (rw,nosuid,nodev,noexec,relatime)
tmpfs on /run/credentials/systemd-journald.service type tmpfs (ro,nosuid,nodev,noexec,relatime,nosymfollow,size=1024k,nr_inodes=1024,mode=700,inode64,noswap)
fusectl on /sys/fs/fuse/connections type fusectl (rw,nosuid,nodev,noexec,relatime)
configfs on /sys/kernel/config type configfs (rw,nosuid,nodev,noexec,relatime)
tmpfs on /tmp type tmpfs (rw,nosuid,nodev,size=8026944k,nr_inodes=1048576,inode64)
/dev/nvme0n1p9 on /home type ext4 (rw,relatime)
/dev/nvme0n1p1 on /boot type vfat (rw,relatime,fmask=0022,dmask=0022,codepage=437,iocharset=ascii,shortname=mixed,utf8,errors=remount-ro)
binfmt_misc on /proc/sys/fs/binfmt_misc type binfmt_misc (rw,nosuid,nodev,noexec,relatime)
tracefs on /sys/kernel/debug/tracing type tracefs (rw,nosuid,nodev,noexec,relatime)
tmpfs on /run/credentials/getty@tty1.service type tmpfs (ro,nosuid,nodev,noexec,relatime,nosymfollow,size=1024k,nr_inodes=1024,mode=700,inode64,noswap)
tmpfs on /run/user/1000 type tmpfs (rw,nosuid,nodev,relatime,size=1605388k,nr_inodes=401347,mode=700,uid=1000,gid=1000,inode64)
portal on /run/user/1000/doc type fuse.portal (rw,nosuid,nodev,relatime,user_id=1000,group_id=1000)

What are all your local file system partition types

nvme0n1
│                                                                          
├─nvme0n1p1
│    vfat   FAT32 ESP         ACDC-AFBC                             563.9M    45% /boot
├─nvme0n1p2
│                                                                          
├─nvme0n1p3
│    ntfs         Windows     EA2AF81D2AF7E50B                             
├─nvme0n1p4
│    ntfs         WINRETOOLS  ECD4ED8DD4ED5A7A                             
├─nvme0n1p5
│    ntfs         Image       7AF2EDD8F2ED98A1                             
├─nvme0n1p6
│    ntfs         DELLSUPPORT DE869AEA869AC287                             
├─nvme0n1p7
│    ext4   1.0               7ad7f5ab-b539-4bac-8043-9ed642b92918    4.5G    83% /
├─nvme0n1p8
│    ext4   1.0               4b9ec2fb-d7d2-4c80-9359-c199e7da959b         
├─nvme0n1p9
│    ext4   1.0               26d565fb-af16-4db4-beb5-4361618e2b80   82.8G    52% /home
└─nvme0n1p10
     swap   1     Swap        531d9bd9-e9ee-47d8-bd9b-f6a89f19eec9                [SWAP]

How do you use 'onedrive'

Sync local files with onedrive account. I only access onedrive from one device at a time.

Steps to reproduce the behaviour

Open a file in sync_dir with neovim and write to it.
Quickly run

stat file.txt

Wait for file to be uploaded to onedrive.
Edit file in neovim and try to write :w
Neovim shows

WARNING: The file has been changed since reading it!!!
Do you really want to write to it (y/n)?

Output of

stat file.txt

shows that modification time has changed (without successfully writing from neovim).

Complete Verbose Log Output

Problem occurs when using --monitor

Screenshots

No response

Other Log Information or Details

Additional context

This only happens when I use onedrive v2.5, not on v2.4.25.

[abraunegg]

@ecasselton
This is technically not a bug - sorry.

When you upload data to Microsoft OneDrive, the Microsoft API changes your file including timestamp.

To ensure that what is online, is what is local, and to ensure values align this is why the local file timestamp is updated.

That 'neovim' reports the file has changed is probably the actual issue. The content has not changed, the timestamp has ....

This only happens when I use onedrive v2.5, not on v2.4.25.

v2.5.x fixed many bugs including many around timestamp and ensuring that what is online is local - so the reason this did not occur with v2.4.25 .. is a v2.4.25 bug

Closing issue as not a bug.

Potentially raise a bug with 'neovim' that they raise a warning when the content changes ... not the timestamp!

[ecasselton]

Thanks @abraunegg for the quick reply, that makes sense.

[abraunegg]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.