Update and add licenses #3470
Merged
Update and add licenses #3470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new licenses - Add the category modification to ofl-1.1 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
update-license-rules
branch
from
5d57544 to
17dd1a2
Compare
AyanSinhaMahapatra
changed the title
AyanSinhaMahapatra
force-pushed
the
update-license-rules
branch
2 times, most recently
from
176d2b0 to
17dd1a2
Compare
AyanSinhaMahapatra
changed the title
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
pombredanne
requested changes
Jul 27, 2023
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks! here are some nits for your consideration.
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Deprecate the hot-potato license and add it as a proprietary rule instead. Reference: #3446 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
update-license-rules
branch
from
7d69d8a to
86a1ac4
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
update-license-rules
branch
from
b711744 to
60f3d5f
Compare
Reference: #3438 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
pombredanne
reviewed
Aug 7, 2023
pombredanne
approved these changes
Aug 7, 2023
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Some minor nits to consider. Please merge then!
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
update-license-rules
branch
from
aee388a to
2a622cc
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
The license clue detection step was in the wrong order for file detections. Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Reference: #3504 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Reference: #3494 Reference: #3499 Reference: #3498 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Reference: #3507 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
pombredanne
approved these changes
Sep 15, 2023
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
LGTM... some tests are not passing though
Member
Author
|
@pombredanne these were the heisenbugs, I've reran the tests, all green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: aboutcode-org/scancode-licensedb#37
Tasks
Run tests locally to check for errors.