counsel--async-command-1: Immediately update minibuffer after spawning #3030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue in counsel-rg and related commands where, if the user quickly types some string that does not have any grep results, and the search takes a long time, then the candidates list will say "1 more chars" while ripgrep is already running and won't be updated until ripgrep exits.
bcc32
force-pushed
the
fix-stale-more-chars
branch
from
375a055 to
81b0655
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in counsel-rg and related commands where, if the user quickly types some string that does not have any grep results, and the search takes a long time, then the candidates list will say "1 more chars" while ripgrep is already running and won't be updated until ripgrep exits.
This change also has the following side-effect, which may or may not be desired: when the user is typing a query string, if the old query string already had some matches, ivy would continue to display them until rg produced results for the new query string. With this change, however, ivy immediately clears the results list when the new rg process is spawned.
Closes #3029