Only enable dynamic exhibit delay while typing #2941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ivy.el (ivy--queue-last-input): New variable holding last input. (ivy--queue-exhibit): Debounce by only starting timer if ivy--input has changed (abo-abo#2941). Otherwise, even moving to another candidate with unchanged input incurs a delay. Fixes abo-abo#1218. Copyright-paperwork-exempt: yes
* ivy.el (ivy-dynamic-exhibit-delay-ms, ivy--exhibit-timer) (ivy--queue-last-input, ivy--exhibit): Fix docstring. (ivy--queue-exhibit): Ditto. Refactor to only compute ivy--input once (abo-abo#2941).
basil-conto
force-pushed
the
dynamic-delay
branch
from
e31a8fd to
fd8df3b
Compare
basil-conto
added
the
enhancement
|
Sorry for the delay (heh), and thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1218
Adds an extra check to
ivy--queue-exhibitto only debounce if the input hasactually changed. It also maintains the previous input variable to match against.