Skip to content

Conversation

@mitch-kyle
Copy link

These changes are what came from me investigating how to change
the appearance of the swiper line numbers. This change should add
some customization support for swiper line numbers using the builtin
display-line-numbers-mode as "sane default"

Three changes were made:

  1. The line numbers are now right justified.
    see: swiper--candidates

  2. The line numbers now have custom faces based on the builtin
    line-number and line-number-current-line faces.
    see: swiper-line-number-face
    swiper-current-line-number-face

  3. The current line number is highlighted. using an ivy format
    function.
    see: swiper--format-function

@mitch-kyle mitch-kyle force-pushed the master branch 2 times, most recently from f24e15c to d2f7569 Compare November 23, 2020 03:15
Copy link
Collaborator

@basil-conto basil-conto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, see some of my initial comments after a quick look through the code.

@mitch-kyle mitch-kyle force-pushed the master branch 2 times, most recently from d365f81 to 7442102 Compare November 23, 2020 19:24
Copy link
Collaborator

@basil-conto basil-conto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from some minor nits/questions.

I'm not sure if this change is small enough to be merged without a copyright assignment, though. Do you already have one on file with the FSF? If not, would you be willing to? If you're not familiar with it, there's some more information at (info "(emacs) Copyright Assignment").

@mitch-kyle
Copy link
Author

mitch-kyle commented Nov 23, 2020

LGTM apart from some minor nits/questions.

I'm not sure if this change is small enough to be merged without a copyright assignment, though. Do you already have one on file with the FSF? If not, would you be willing to? If you're not familiar with it, there's some more information at (info "(emacs) Copyright Assignment").

I don't but I'm willing to. I'll let you know when the paperwork goes through

@basil-conto basil-conto added the waiting-for-ca Waiting for author's copyright assignment label Nov 23, 2020
Three changes were made to the 'swiper' line numbers to make it more
like the builtin 'display-line-numbers-mode'

1. The line numbers are now right justified
   see: 'swiper--candidates'

2. The line numbers now have custom faces based on the builtin
   line-number and line-number-current-line faces
   see: 'swiper-line-number-face'
        'swiper-current-line-number-face'

3. The current line number is highlighted. using an ivy format
   function
   see 'swiper--format-function'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-ca Waiting for author's copyright assignment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants