Open
Conversation
|
Wait this actually looks fire, why hasn't this been merged |
|
Yeah, this looks really cool! The code for this is short and sweet, would love to see it merged! |
|
You save my day.. really thanks! |
Author
|
Hi @abetlen. Thank you for your support. May I have your opinion on this PR? |
| normalize: bool = False, | ||
| truncate: bool = True, | ||
| return_count: bool = False, | ||
| special_tokenize: bool = False, |
There was a problem hiding this comment.
Hi @yutyan0119 ,
This is an awesome PR. Nice work! I use this almost everyday.
I have a suggestion. Would it be better to rename the arg. 'special_tokenize' -> 'add_special_tokens'? As the tokenizer endpoint has a arg. named 'add_special', this renaming would bring better fluency.
Moreover, I would like you to add an error handling mechanism as follows:
- If the "documents" is an empty list then, return None.
I have faced this issue a few times and this will be a nice "user-comfort" edit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hello @abetlen! Thank you for your work on this library.
This PR introduces a new rank method in the Llama class, enabling users to rank documents based on their relevance to a given query. This functionality is useful for tasks such as document retrieval and relevance scoring within a list of documents. This addition corresponds to the feature introduced in llama.cpp PR #9510 and also addresses the request for re-ranking support mentioned in Issue #1794.
Changes Made:
1. New Method: rank
2. Embed Method Enhancement
Usage Example
output